crypto/ipsec_mb: fix queue cleanup null pointer dereference

The qp was being used in the cleanup without checking if it was non NULL.
A check is now added to verify qp is non NULL before use.

Coverity issue: 374375
Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index 6efa417d67918bfd15740334f5e3aa86386f3318..1ebd23e8f07322253abbca49753a311f48a44ba0 100644 (file)
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -285,6 +285,8 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
        return 0;
 
 qp_setup_cleanup:
+       if (qp == NULL)
+               return ret;
 #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
        if (qp->mb_mgr)
                free_mb_mgr(qp->mb_mgr);
@@ -294,8 +296,7 @@ qp_setup_cleanup:
        if (qp->mb_mgr_mz)
                rte_memzone_free(qp->mb_mgr_mz);
 #endif
-       if (qp)
-               rte_free(qp);
+       rte_free(qp);
        return ret;
 }