]> git.droids-corp.org - dpdk.git/commitdiff
ethdev: fix possible null pointer access
authorChengwen Feng <fengchengwen@huawei.com>
Fri, 13 May 2022 02:53:56 +0000 (10:53 +0800)
committerAndrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Fri, 20 May 2022 14:45:52 +0000 (16:45 +0200)
The rte_tel_data_alloc() may return NULL, so the caller should add
judgement for it.

Fixes: 083b0b310b19 ("ethdev: add common stats for telemetry")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
lib/ethdev/rte_ethdev.c

index dc47543e6bf3870ecb57063e13c215087509c5af..a1758676514cbea822b610786e9def8e8b45a5e9 100644 (file)
@@ -5502,6 +5502,8 @@ eth_dev_add_port_queue_stats(struct rte_tel_data *d, uint64_t *q_stats,
 {
        int q;
        struct rte_tel_data *q_data = rte_tel_data_alloc();
+       if (q_data == NULL)
+               return;
        rte_tel_data_start_array(q_data, RTE_TEL_U64_VAL);
        for (q = 0; q < RTE_ETHDEV_QUEUE_STAT_CNTRS; q++)
                rte_tel_data_add_array_u64(q_data, q_stats[q]);