]> git.droids-corp.org - dpdk.git/commitdiff
net/mlx5: fix RSS RETA update
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Wed, 27 Oct 2021 14:22:12 +0000 (16:22 +0200)
committerMaxime Coquelin <maxime.coquelin@redhat.com>
Fri, 29 Oct 2021 09:23:10 +0000 (11:23 +0200)
This patch fixes RETA updating for entries above 64.
Without that, these entries are never updated as
calculated mask value will always be 0.

Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
Cc: stable@dpdk.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
drivers/net/mlx5/mlx5_rss.c

index a4f690039e2421c2e3c324a0fec0af8517369218..a04e22398dbd39796fd5d22929affc643996763f 100644 (file)
@@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
        for (idx = 0, i = 0; (i != reta_size); ++i) {
                idx = i / RTE_ETH_RETA_GROUP_SIZE;
                pos = i % RTE_ETH_RETA_GROUP_SIZE;
-               if (((reta_conf[idx].mask >> i) & 0x1) == 0)
+               if (((reta_conf[idx].mask >> pos) & 0x1) == 0)
                        continue;
                MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
                (*priv->reta_idx)[i] = reta_conf[idx].reta[pos];