ixgbe: fix setup of mbuf initializer template
authorJean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Thu, 4 Dec 2014 14:26:20 +0000 (15:26 +0100)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Fri, 5 Dec 2014 21:49:25 +0000 (22:49 +0100)
Add a compiler barrier to make sure all fields covered by
the marker rearm_data are assigned before the read.

Fixes: 0ff3324da2 ("ixgbe: rework vector pmd following mbuf changes")

Signed-off-by: Jean-Mickael Guerin <jean-mickael.guerin@6wind.com>
Acked-by: David Marchand <david.marchand@6wind.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c

index 579bc46..c1b5a78 100644 (file)
@@ -739,6 +739,9 @@ ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq)
        mb_def.buf_len = rxq->mb_pool->elt_size - sizeof(struct rte_mbuf);
        mb_def.port = rxq->port_id;
        rte_mbuf_refcnt_set(&mb_def, 1);
+
+       /* prevent compiler reordering: rearm_data covers previous fields */
+       rte_compiler_barrier();
        rxq->mbuf_initializer = *((uint64_t *)&mb_def.rearm_data);
        return 0;
 }