]> git.droids-corp.org - dpdk.git/commitdiff
common/cnxk: fix bitmap usage for TM
authorNithin Dabilpuram <ndabilpuram@marvell.com>
Thu, 3 Mar 2022 07:00:41 +0000 (12:30 +0530)
committerJerin Jacob <jerinj@marvell.com>
Thu, 3 Mar 2022 17:28:16 +0000 (18:28 +0100)
Revert change [1] to return error on case where no slab of free
resources is found. That error check break's a case where
there is a spare schedule queue to be reused that was just
allocated for sake of contiguous static TM nodes.

[1]
Fixes: 14f7e5d4bf2d ("common/cnxk: add missing checks of return values")
Cc: stable@dpdk.org
Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
drivers/common/cnxk/roc_nix_tm.c

index 7a1778005893f20a890d318d7af4dc783f8fb9ee..5b70c7bfeda416aa439364cd7636e22031b9d1a9 100644 (file)
@@ -1042,10 +1042,8 @@ nix_tm_assign_hw_id(struct nix *nix, struct nix_tm_node *parent,
                        return -EFAULT;
                }
 
-               if (!slab) {
-                       if (!plt_bitmap_scan(bmp, &pos, &slab))
-                               return -ENOENT;
-               }
+               if (!slab)
+                       plt_bitmap_scan(bmp, &pos, &slab);
 
                if (child->priority == parent->rr_prio && spare_schq != -1) {
                        /* Use spare schq first if present */