kni: fix build with vhost header enabled
authorMiguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Fri, 26 Jun 2015 22:14:38 +0000 (17:14 -0500)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Fri, 10 Jul 2015 09:59:15 +0000 (11:59 +0200)
A missing port from memcpy_toiovecend to copy_to_iter
is showed when vHost HDR is enabled. DPDK would not build.

This patch add this validation to build with kernel > 3.19.

Fixes: 45e63ba8db31 ("kni: fix vhost build with kernels 3.19 and 4.0")
Linux: ba7438aed924 ("vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()")

Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
lib/librte_eal/linuxapp/kni/kni_vhost.c

index f21b47e..013a677 100644 (file)
@@ -427,10 +427,15 @@ kni_sock_rcvmsg(struct socket *sock,
 
 #ifdef RTE_KNI_VHOST_VNET_HDR_EN
        /* no need to copy hdr when no pkt received */
+#ifdef HAVE_IOV_ITER_MSGHDR
+       if (unlikely(copy_to_iter((void *)&vnet_hdr, vnet_hdr_len,
+               &m->msg_iter)))
+#else
        if (unlikely(memcpy_toiovecend(m->msg_iov,
                (void *)&vnet_hdr, 0, vnet_hdr_len)))
+#endif /* HAVE_IOV_ITER_MSGHDR */
                return -EFAULT;
-#endif
+#endif /* RTE_KNI_VHOST_VNET_HDR_EN */
        KNI_DBG_RX("kni_rcvmsg expect_len %ld, flags 0x%08x, pkt_len %d\n",
                   (unsigned long)len, q->flags, pkt_len);