]> git.droids-corp.org - dpdk.git/commitdiff
app/testpmd: fix L2TPv2 message type
authorJie Wang <jie1x.wang@intel.com>
Wed, 27 Oct 2021 02:01:52 +0000 (10:01 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 28 Oct 2021 18:04:03 +0000 (20:04 +0200)
In "msg_type |= 0xc800", wider "51200" has high-order bits (0xc800)
that don't affect the narrower left-hand side.

This patch fixes coverity issue by changing the definition type of
"msg_type" from uint8_t to uint16_t.

Coverity issue: 373651
Fixes: 748530f0354e ("app/testpmd: support L2TPv2 and PPP protocol pattern")
Signed-off-by: Jie Wang <jie1x.wang@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
app/test-pmd/cmdline_flow.c

index d8218771fb943166ee2ef06bc04fc7e5111bd72c..24b224e63264bfdd08a5ded535e97e4d9e6a38a2 100644 (file)
@@ -5880,7 +5880,7 @@ parse_vc_item_l2tpv2_type(struct context *ctx, const struct token *token,
        struct rte_flow_item_l2tpv2 *l2tpv2_mask;
        struct rte_flow_item *item;
        uint32_t data_size;
-       uint8_t msg_type = 0;
+       uint16_t msg_type = 0;
        struct buffer *out = buf;
        const struct arg *arg;