]> git.droids-corp.org - dpdk.git/commitdiff
raw/cnxk_gpio: allow controlling existing GPIO
authorTomasz Duszynski <tduszynski@marvell.com>
Sat, 4 Jun 2022 14:03:23 +0000 (16:03 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 8 Jun 2022 08:56:54 +0000 (10:56 +0200)
Controlling existing GPIO should be normally frowned upon because
we want to avoid situation where multiple contenders modify GPIO
state simultaneously.

Still there might be situations where this is actually needed.
Restarting killed application being an example here.

So relax current restrictions and respect user needs.

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
drivers/raw/cnxk_gpio/cnxk_gpio.c

index 95777538512f7d75ad7aee729641def05d385286..d759ed82d4d147ea3a0137ac50e5217d3250abfb 100644 (file)
@@ -4,6 +4,7 @@
 
 #include <dirent.h>
 #include <string.h>
+#include <sys/stat.h>
 
 #include <rte_bus_vdev.h>
 #include <rte_eal.h>
@@ -277,6 +278,17 @@ cnxk_gpio_lookup(struct cnxk_gpiochip *gpiochip, uint16_t queue)
        return gpiochip->gpios[gpio];
 }
 
+static bool
+cnxk_gpio_exists(int num)
+{
+       char buf[CNXK_GPIO_BUFSZ];
+       struct stat st;
+
+       snprintf(buf, sizeof(buf), "%s/gpio%d", CNXK_GPIO_CLASS_PATH, num);
+
+       return !stat(buf, &st);
+}
+
 static int
 cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id,
                      rte_rawdev_obj_t queue_conf, size_t queue_conf_size)
@@ -304,11 +316,15 @@ cnxk_gpio_queue_setup(struct rte_rawdev *dev, uint16_t queue_id,
        gpio->num = num + gpiochip->base;
        gpio->gpiochip = gpiochip;
 
-       snprintf(buf, sizeof(buf), "%s/export", CNXK_GPIO_CLASS_PATH);
-       ret = cnxk_gpio_write_attr_int(buf, gpio->num);
-       if (ret) {
-               rte_free(gpio);
-               return ret;
+       if (!cnxk_gpio_exists(gpio->num)) {
+               snprintf(buf, sizeof(buf), "%s/export", CNXK_GPIO_CLASS_PATH);
+               ret = cnxk_gpio_write_attr_int(buf, gpio->num);
+               if (ret) {
+                       rte_free(gpio);
+                       return ret;
+               }
+       } else {
+               RTE_LOG(WARNING, PMD, "using existing gpio%d\n", gpio->num);
        }
 
        gpiochip->gpios[num] = gpio;