]> git.droids-corp.org - dpdk.git/commitdiff
net/qede: fix redundant condition in debug code
authorAnatoly Burakov <anatoly.burakov@intel.com>
Tue, 30 Nov 2021 16:59:13 +0000 (16:59 +0000)
committerJerin Jacob <jerinj@marvell.com>
Tue, 11 Jan 2022 12:02:14 +0000 (13:02 +0100)
Expression "a && 1" is equivalent to just "a", so fix the accidental
inclusion of a literal in code.

Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
drivers/net/qede/qede_debug.c

index af86bcc69219ff76d154ffc551aa4abcea8fd185..9383a6d6771445db5c5008f628407226b5a233c5 100644 (file)
@@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn,
 
        /* Dump MCP HW Dump */
        if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
-           !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)
+           !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
                offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
                                                   p_ptt,
                                                   dump_buf + offset, dump);