net/hns3: check PCI config space write
authorLijun Ou <oulijun@huawei.com>
Mon, 9 Nov 2020 14:29:00 +0000 (22:29 +0800)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 13 Nov 2020 18:43:26 +0000 (19:43 +0100)
Here adds a check for the return value when calling
rte_pci_write_config.

Coverity issue: 363714
Fixes: cea37e513329 ("net/hns3: fix FLR reset")
Cc: stable@dpdk.org
Signed-off-by: Lijun Ou <oulijun@huawei.com>
drivers/net/hns3/hns3_ethdev_vf.c

index 6f71cd6..1535f26 100644 (file)
@@ -148,8 +148,12 @@ hns3vf_enable_msix(const struct rte_pci_device *device, bool op)
                        control |= PCI_MSIX_FLAGS_ENABLE;
                else
                        control &= ~PCI_MSIX_FLAGS_ENABLE;
-               rte_pci_write_config(device, &control, sizeof(control),
-                                    (pos + PCI_MSIX_FLAGS));
+               ret = rte_pci_write_config(device, &control, sizeof(control),
+                                         (pos + PCI_MSIX_FLAGS));
+               if (ret < 0) {
+                       PMD_INIT_LOG(ERR, "failed to write PCI offset 0x%x",
+                                   (pos + PCI_MSIX_FLAGS));
+               }
                return 0;
        }
        return -ENXIO;