]> git.droids-corp.org - dpdk.git/commitdiff
bus/fslmc: integrate dpio and dpbp to object framework
authorNipun Gupta <nipun.gupta@nxp.com>
Fri, 30 Jun 2017 08:54:18 +0000 (14:24 +0530)
committerJerin Jacob <jerin.jacob@caviumnetworks.com>
Fri, 7 Jul 2017 07:25:02 +0000 (09:25 +0200)
This patch removes the existing static call for dpio and dpbp
create and add them to object registration framework.

This patch also changes the vfio mc object processing to use
the framework.

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
drivers/bus/fslmc/fslmc_vfio.c
drivers/bus/fslmc/fslmc_vfio.h
drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c
drivers/bus/fslmc/portal/dpaa2_hw_dpio.c

index e7a1ca9e87376405607f86bb3d8d8d2582808c4d..a8002c92de2fe291a1e5c9ede7da25f3727d2c49 100644 (file)
@@ -383,7 +383,6 @@ int fslmc_vfio_process_group(void)
        char path[PATH_MAX];
        int64_t v_addr;
        int ndev_count;
-       int dpio_count = 0, dpbp_count = 0;
        struct fslmc_vfio_group *group = &vfio_groups[0];
        static int process_once;
 
@@ -522,18 +521,17 @@ int fslmc_vfio_process_group(void)
                                      object_type, object_id);
 
                        fslmc_bus_add_device(dev);
-               }
-               if (!strcmp(object_type, "dpio")) {
-                       ret = dpaa2_create_dpio_device(vdev,
-                                                      &device_info,
+               } else {
+                       /* Parse all other objects */
+                       struct rte_dpaa2_object *object;
+
+                       TAILQ_FOREACH(object, &fslmc_obj_list, next) {
+                               if (!strcmp(object_type, object->name))
+                                       object->create(vdev, &device_info,
                                                       object_id);
-                       if (!ret)
-                               dpio_count++;
-               }
-               if (!strcmp(object_type, "dpbp")) {
-                       ret = dpaa2_create_dpbp_device(object_id);
-                       if (!ret)
-                               dpbp_count++;
+                               else
+                                       continue;
+                       }
                }
        }
        closedir(d);
@@ -542,8 +540,6 @@ int fslmc_vfio_process_group(void)
        if (ret)
                FSLMC_VFIO_LOG(DEBUG, "Error in affining qbman swp %d", ret);
 
-       FSLMC_VFIO_LOG(DEBUG, "DPAA2: Added dpbp_count = %d dpio_count=%d",
-                     dpbp_count, dpio_count);
        return 0;
 
 FAILURE:
index 58b3acde5b379e4d8676ba3131a0733f047050b2..ffed62eb017d37c89d9e5c242da69edb4f3e3b7e 100644 (file)
@@ -39,6 +39,8 @@
 #define DPAA2_VENDOR_ID                0x1957
 #define DPAA2_MC_DPNI_DEVID    7
 #define DPAA2_MC_DPSECI_DEVID  3
+#define DPAA2_MC_DPIO_DEVID    9
+#define DPAA2_MC_DPBP_DEVID    10
 
 #define VFIO_MAX_GRP 1
 
@@ -90,13 +92,6 @@ int fslmc_vfio_setup_group(void);
 int fslmc_vfio_process_group(void);
 int rte_fslmc_vfio_dmamap(void);
 
-/* create dpio device */
-int dpaa2_create_dpio_device(struct fslmc_vfio_device *vdev,
-                            struct vfio_device_info *obj_info,
-                            int object_id);
-
-int dpaa2_create_dpbp_device(int dpbp_id);
-
 /**
  * Register a DPAA2 MC Object driver.
  *
index a665ec5c9f02a0eb213f5619ad4edc5651399563..b55335a3d00b6facb11464f6a3ef45c2710fcbd3 100644 (file)
@@ -57,9 +57,10 @@ TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev);
 static struct dpbp_dev_list dpbp_dev_list
        = TAILQ_HEAD_INITIALIZER(dpbp_dev_list); /*!< DPBP device list */
 
-int
-dpaa2_create_dpbp_device(
-               int dpbp_id)
+static int
+dpaa2_create_dpbp_device(struct fslmc_vfio_device *vdev __rte_unused,
+                        struct vfio_device_info *obj_info __rte_unused,
+                        int dpbp_id)
 {
        struct dpaa2_dpbp_dev *dpbp_node;
        int ret;
@@ -127,3 +128,10 @@ void dpaa2_free_dpbp_dev(struct dpaa2_dpbp_dev *dpbp)
                }
        }
 }
+
+static struct rte_dpaa2_object rte_dpaa2_dpbp_obj = {
+       .object_id = DPAA2_MC_DPBP_DEVID,
+       .create = dpaa2_create_dpbp_device,
+};
+
+RTE_PMD_REGISTER_DPAA2_OBJECT(dpbp, rte_dpaa2_dpbp_obj);
index 4c4e9186749fbfc2c46654e69e60cfd27c711b6c..c626c12a49295eaed724b5ead1317baf3703d7e8 100644 (file)
@@ -334,10 +334,10 @@ dpaa2_affine_qbman_swp_sec(void)
        }
 }
 
-int
+static int
 dpaa2_create_dpio_device(struct fslmc_vfio_device *vdev,
                         struct vfio_device_info *obj_info,
-               int object_id)
+                        int object_id)
 {
        struct dpaa2_dpio_dev *dpio_dev;
        struct vfio_region_info reg_info = { .argsz = sizeof(reg_info)};
@@ -442,3 +442,10 @@ fail:
 
        return -1;
 }
+
+static struct rte_dpaa2_object rte_dpaa2_dpio_obj = {
+       .object_id = DPAA2_MC_DPIO_DEVID,
+       .create = dpaa2_create_dpio_device,
+};
+
+RTE_PMD_REGISTER_DPAA2_OBJECT(dpio, rte_dpaa2_dpio_obj);