ipc: handle more invalid parameter cases
authorAnatoly Burakov <anatoly.burakov@intel.com>
Mon, 29 Apr 2019 13:59:28 +0000 (14:59 +0100)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 3 May 2019 12:52:49 +0000 (14:52 +0200)
Length of buffer and number of fd's to send are signed values, so
they can be negative, but the API doesn't check for that. Fix it
by checking for negative values as well.

Fixes: bacaa2754017 ("eal: add channel for multi-process communication")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
lib/librte_eal/common/eal_common_proc.c

index 6ffd476..d098803 100644 (file)
@@ -761,6 +761,18 @@ check_input(const struct rte_mp_msg *msg)
        if (validate_action_name(msg->name))
                return false;
 
+       if (msg->len_param < 0) {
+               RTE_LOG(ERR, EAL, "Message data length is negative\n");
+               rte_errno = EINVAL;
+               return false;
+       }
+
+       if (msg->num_fds < 0) {
+               RTE_LOG(ERR, EAL, "Number of fd's is negative\n");
+               rte_errno = EINVAL;
+               return false;
+       }
+
        if (msg->len_param > RTE_MP_MAX_PARAM_LEN) {
                RTE_LOG(ERR, EAL, "Message data is too long\n");
                rte_errno = E2BIG;