test/rwlock: amortize the cost of getting time
authorJoyce Kong <joyce.kong@arm.com>
Mon, 25 Mar 2019 09:14:59 +0000 (17:14 +0800)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 28 Mar 2019 10:49:36 +0000 (11:49 +0100)
Instead of getting timestamp per iteration, amortize its
overhead can help to get more precise benchmarking results.

Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
app/test/test_rwlock.c

index 1d3774e..c3d656a 100644 (file)
@@ -86,9 +86,9 @@ test_rwlock_per_core(__attribute__((unused)) void *arg)
 
 static rte_rwlock_t lk = RTE_RWLOCK_INITIALIZER;
 static volatile uint64_t rwlock_data;
-static uint64_t lock_count[RTE_MAX_LCORE] = {0};
+static uint64_t time_count[RTE_MAX_LCORE] = {0};
 
-#define TIME_MS 100
+#define MAX_LOOP 10000
 #define TEST_RWLOCK_DEBUG 0
 
 static int
@@ -105,7 +105,7 @@ load_loop_fn(__attribute__((unused)) void *arg)
                        ;
 
        begin = rte_rdtsc_precise();
-       while (time_diff < hz * TIME_MS / 1000) {
+       while (lcount < MAX_LOOP) {
                rte_rwlock_write_lock(&lk);
                ++rwlock_data;
                rte_rwlock_write_unlock(&lk);
@@ -119,10 +119,10 @@ load_loop_fn(__attribute__((unused)) void *arg)
                lcount++;
                /* delay to make lock duty cycle slightly realistic */
                rte_pause();
-               time_diff = rte_rdtsc_precise() - begin;
        }
 
-       lock_count[lcore] = lcount;
+       time_diff = rte_rdtsc_precise() - begin;
+       time_count[lcore] = time_diff * 1000000 / hz;
        return 0;
 }
 
@@ -146,11 +146,13 @@ test_rwlock_perf(void)
        rte_eal_mp_wait_lcore();
 
        RTE_LCORE_FOREACH(i) {
-               printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]);
-               total += lock_count[i];
+               printf("Core [%u] cost time = %"PRIu64" us\n",
+                       i, time_count[i]);
+               total += time_count[i];
        }
 
-       printf("Total count = %"PRIu64"\n", total);
+       printf("Total cost time = %"PRIu64" us\n", total);
+       memset(time_count, 0, sizeof(time_count));
 
        return 0;
 }