net/mlx5: fix flex item availability
authorGregory Etelson <getelson@nvidia.com>
Wed, 2 Mar 2022 11:06:42 +0000 (13:06 +0200)
committerRaslan Darawsheh <rasland@nvidia.com>
Mon, 7 Mar 2022 10:43:12 +0000 (11:43 +0100)
Flex item availability is restricted to BlueField-2 and BlueField-3
PF ports.

The patch validates port type compliance before proceeding to
flex item creation.

Fixes: db25cadc0887 ("net/mlx5: add flex item operations")
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
drivers/common/mlx5/linux/mlx5_common_os.h
drivers/net/mlx5/mlx5_flow.c

index a85f3b5..27f1192 100644 (file)
@@ -9,6 +9,7 @@
 #include <malloc.h>
 
 #include <rte_pci.h>
+#include <rte_bus_pci.h>
 #include <rte_debug.h>
 #include <rte_atomic.h>
 #include <rte_log.h>
index 15a4a8c..ffcaef0 100644 (file)
@@ -10630,10 +10630,27 @@ mlx5_flow_flex_item_create(struct rte_eth_dev *dev,
                           struct rte_flow_error *error)
 {
        static const char err_msg[] = "flex item creation unsupported";
+       struct mlx5_priv *priv = dev->data->dev_private;
        struct rte_flow_attr attr = { .transfer = 0 };
        const struct mlx5_flow_driver_ops *fops =
                        flow_get_drv_ops(flow_get_drv_type(dev, &attr));
 
+       if (!priv->pci_dev) {
+               rte_flow_error_set(error, ENOTSUP,
+                                  RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+                                  "create flex item on PF only");
+               return NULL;
+       }
+       switch (priv->pci_dev->id.device_id) {
+       case PCI_DEVICE_ID_MELLANOX_CONNECTX6DXBF:
+       case PCI_DEVICE_ID_MELLANOX_CONNECTX7BF:
+               break;
+       default:
+               rte_flow_error_set(error, ENOTSUP,
+                                  RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+                                  "flex item available on BlueField ports only");
+               return NULL;
+       }
        if (!fops->item_create) {
                DRV_LOG(ERR, "port %u %s.", dev->data->port_id, err_msg);
                rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION,