net/bnxt: fix build
authorAjit Khaparde <ajit.khaparde@broadcom.com>
Thu, 8 Jul 2021 22:09:18 +0000 (15:09 -0700)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 9 Jul 2021 20:34:06 +0000 (22:34 +0200)
Fix build failures seen on Fedora Core 34 (GCC 11)
because of uninitialized variables.

In function ‘ulp_mapper_index_tbl_process’:
drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error:
‘*(unsigned int *)((char *)&glb_res + offsetof(struct bnxt_ulp_glb_resource_info, resource_func))’
may be used uninitialized in this function
 2252 |         struct bnxt_ulp_glb_resource_info glb_res;
      |                                           ^~~~~~~
drivers/net/bnxt/tf_ulp/ulp_mapper.c:2252:43: error:
‘glb_res.resource_type’ may be used uninitialized in this function

In function ‘dpool_defrag’:
drivers/net/bnxt/tf_core/dpool.c:95:18: error:
‘index’ may be used uninitialized in this function
   95 |         uint32_t index;
      |                  ^~~~~

Fixes: 05b405d58148 ("net/bnxt: add dpool allocator for EM allocation")

Signed-off-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
drivers/net/bnxt/tf_core/dpool.c
drivers/net/bnxt/tf_ulp/ulp_mapper.c

index 0dae42b..145efa4 100644 (file)
@@ -125,6 +125,7 @@ int dpool_defrag(struct dpool *dpool,
                largest_free_size = 0;
                largest_free_index = 0;
                count = 0;
+               index = 0;
 
                for (i = 0; i < dpool->size; i++) {
                        if (DP_IS_FREE(dpool->entry[i].flags)) {
index acd9f99..871dbad 100644 (file)
@@ -2249,7 +2249,7 @@ ulp_mapper_index_tbl_process(struct bnxt_ulp_mapper_parms *parms,
        struct tf_free_tbl_entry_parms free_parms = { 0 };
        uint32_t tbl_scope_id;
        struct tf *tfp;
-       struct bnxt_ulp_glb_resource_info glb_res;
+       struct bnxt_ulp_glb_resource_info glb_res = { 0 };
        uint16_t bit_size;
        bool alloc = false;
        bool write = false;