net/i40e: fix MAC removal check
authorHerakliusz Lipiec <herakliusz.lipiec@intel.com>
Thu, 18 Jul 2019 14:44:48 +0000 (15:44 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 23 Jul 2019 12:31:35 +0000 (14:31 +0200)
Add return value check for i40e_vsi_delete_mac call in
rte_pmd_i40e_remove_vf_mac_addr as per coverity issue.

Coverity issue: 277224
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Cc: stable@dpdk.org
Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
Acked-by: Beilei Xing <beilei.xing@intel.com>
drivers/net/i40e/rte_pmd_i40e.c

index 24281c2..4c3c708 100644 (file)
@@ -581,6 +581,7 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, uint16_t vf_id,
        struct i40e_pf_vf *vf;
        struct i40e_vsi *vsi;
        struct i40e_pf *pf;
+       int ret;
 
        if (i40e_validate_mac_addr((u8 *)mac_addr) != I40E_SUCCESS)
                return -EINVAL;
@@ -609,8 +610,9 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, uint16_t vf_id,
                rte_ether_addr_copy(&null_mac_addr, &vf->mac_addr);
 
        /* Remove the mac */
-       i40e_vsi_delete_mac(vsi, mac_addr);
-
+       ret = i40e_vsi_delete_mac(vsi, mac_addr);
+       if (ret != I40E_SUCCESS)
+               return ret;
        return 0;
 }