]> git.droids-corp.org - dpdk.git/commitdiff
net/af_xdp: add missing trailing newline in logs
authorDavid Marchand <david.marchand@redhat.com>
Thu, 17 Feb 2022 13:06:14 +0000 (14:06 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 17 Feb 2022 17:47:57 +0000 (18:47 +0100)
Caught while trying --in-memory mode, some log messages in this driver
are not terminated with a newline:
rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC
callback: Operation not supportedvdev_probe(): failed to initialize
net_af_xdp device

Other locations in this driver had the same issue, fix all at once.

Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
Fixes: 9876cf8316b3 ("net/af_xdp: re-enable secondary process support")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ciara Loftus <ciara.loftus@intel.com>
drivers/net/af_xdp/rte_eth_af_xdp.c

index 2163df7c5cbe6124ae82bc7d42b3c8c1913831cf..69dfa1b898e914d51d59c68c2216c7d9413a01de 100644 (file)
@@ -1071,7 +1071,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
                umem = rte_zmalloc_socket("umem", sizeof(*umem), 0,
                                          rte_socket_id());
                if (umem == NULL) {
-                       AF_XDP_LOG(ERR, "Failed to allocate umem info");
+                       AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
                        return NULL;
                }
 
@@ -1084,7 +1084,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
                ret = xsk_umem__create(&umem->umem, base_addr, umem_size,
                                &rxq->fq, &rxq->cq, &usr_config);
                if (ret) {
-                       AF_XDP_LOG(ERR, "Failed to create umem");
+                       AF_XDP_LOG(ERR, "Failed to create umem\n");
                        goto err;
                }
                umem->buffer = base_addr;
@@ -1124,7 +1124,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
 
        umem = rte_zmalloc_socket("umem", sizeof(*umem), 0, rte_socket_id());
        if (umem == NULL) {
-               AF_XDP_LOG(ERR, "Failed to allocate umem info");
+               AF_XDP_LOG(ERR, "Failed to allocate umem info\n");
                return NULL;
        }
 
@@ -1160,7 +1160,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,
                               &usr_config);
 
        if (ret) {
-               AF_XDP_LOG(ERR, "Failed to create umem");
+               AF_XDP_LOG(ERR, "Failed to create umem\n");
                goto err;
        }
        umem->mz = mz;
@@ -1847,7 +1847,7 @@ afxdp_mp_request_fds(const char *name, struct rte_eth_dev *dev)
        AF_XDP_LOG(DEBUG, "Sending multi-process IPC request for %s\n", name);
        ret = rte_mp_request_sync(&request, &replies, &timeout);
        if (ret < 0 || replies.nb_received != 1) {
-               AF_XDP_LOG(ERR, "Failed to request fds from primary: %d",
+               AF_XDP_LOG(ERR, "Failed to request fds from primary: %d\n",
                           rte_errno);
                return -1;
        }
@@ -1996,7 +1996,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)
        if (!afxdp_dev_count) {
                ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);
                if (ret < 0 && rte_errno != ENOTSUP) {
-                       AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s",
+                       AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s\n",
                                   name, strerror(rte_errno));
                        return -1;
                }