net/failsafe: fix Rx burst infinite loop
authorMatan Azrad <matan@mellanox.com>
Wed, 24 Jan 2018 10:19:17 +0000 (10:19 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 29 Jan 2018 09:04:28 +0000 (10:04 +0100)
In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst
function for packet receiving.

This function iterates over the present sub-devices until it
receives a traffic from one of them or they are all cannot receive
packets.

The corrupted code didn't advance the sub-device pointer when the
sub-device was not present and caused to infinite loop.

Advance the sub-device pointer also in plugged-out sub-device case.

Fixes: 8052bbd9d548 ("net/failsafe: improve Rx sub-devices iteration")

Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
drivers/net/failsafe/failsafe_rxtx.c

index 1654494..aeee076 100644 (file)
@@ -104,6 +104,7 @@ failsafe_rx_burst(void *queue,
        do {
                if (fs_rx_unsafe(sdev)) {
                        nb_rx = 0;
+                       sdev = sdev->next;
                        continue;
                }
                sub_rxq = ETH(sdev)->data->rx_queues[rxq->qid];