ethdev: fix port state when stop

Currently, 'dev_started' is always set to be 0 when dev stop, whether
it succeeded or failed. This is unreasonable and this patch fixed it.

Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index a1758676514cbea822b610786e9def8e8b45a5e9..fe64f8d39da8ebc697294fc0167882202e168e4e 100644 (file)
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1533,8 +1533,9 @@ rte_eth_dev_stop(uint16_t port_id)
        /* point fast-path functions to dummy ones */
        eth_dev_fp_ops_reset(rte_eth_fp_ops + port_id);
 
-       dev->data->dev_started = 0;
        ret = (*dev->dev_ops->dev_stop)(dev);
+       if (ret == 0)
+               dev->data->dev_started = 0;
        rte_ethdev_trace_stop(port_id, ret);
 
        return ret;