net/ena: remove useless address check
authorFerruh Yigit <ferruh.yigit@intel.com>
Mon, 4 Oct 2021 17:27:02 +0000 (18:27 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 11 Oct 2021 15:47:31 +0000 (17:47 +0200)
Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":

./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
./drivers/net/ena/ena_rss.c:140:66:
error: the comparison will always evaluate as ‘false’ for the
pointer operand in ‘reta_conf + 136’ must not be NULL
[-Werror=address]
  140 |  (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
      |                                                       ^~

Fixing it by removing useless check.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
drivers/net/ena/ena_rss.c

index 88afe13..1520984 100644 (file)
@@ -136,8 +136,7 @@ int ena_rss_reta_query(struct rte_eth_dev *dev,
        int reta_conf_idx;
        int reta_idx;
 
-       if (reta_size == 0 || reta_conf == NULL ||
-           (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
+       if (reta_size == 0 || reta_conf == NULL)
                return -EINVAL;
 
        if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) {