ethdev: check if queues are allocated before getting info
authorFerruh Yigit <ferruh.yigit@intel.com>
Thu, 1 Oct 2020 18:14:02 +0000 (19:14 +0100)
committerFerruh Yigit <ferruh.yigit@intel.com>
Thu, 8 Oct 2020 17:58:11 +0000 (19:58 +0200)
A crash is detected when '--txpkts=#' parameter provided to the testpmd,
this is because queue information is requested before queues have been
allocated.

Adding check to queue info APIs
('rte_eth_rx_queue_info_get()' & 'rte_eth_tx_queue_info_get')
to protect against similar cases.

Fixes: ba2fb4f022fc ("ethdev: check if queue setup when getting queue info")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
lib/librte_ethdev/rte_ethdev.c

index b51ab9b..89858ab 100644 (file)
@@ -4688,7 +4688,8 @@ rte_eth_rx_queue_info_get(uint16_t port_id, uint16_t queue_id,
                return -EINVAL;
        }
 
-       if (dev->data->rx_queues[queue_id] == NULL) {
+       if (dev->data->rx_queues == NULL ||
+                       dev->data->rx_queues[queue_id] == NULL) {
                RTE_ETHDEV_LOG(ERR,
                               "Rx queue %"PRIu16" of device with port_id=%"
                               PRIu16" has not been setup\n",
@@ -4727,7 +4728,8 @@ rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id,
                return -EINVAL;
        }
 
-       if (dev->data->tx_queues[queue_id] == NULL) {
+       if (dev->data->tx_queues == NULL ||
+                       dev->data->tx_queues[queue_id] == NULL) {
                RTE_ETHDEV_LOG(ERR,
                               "Tx queue %"PRIu16" of device with port_id=%"
                               PRIu16" has not been setup\n",