net/nfp: fix possible memory leak
authorAlejandro Lucero <alejandro.lucero@netronome.com>
Wed, 8 Nov 2017 14:42:23 +0000 (14:42 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 10 Nov 2017 09:31:24 +0000 (09:31 +0000)
Memory allocated was not being released in any exit path.

Coverity issue: 195030
Fixes: 48e2255f1b63 ("net/nfp: add NSP support for HW link configuration")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
drivers/net/nfp/nfp_nspu.c

index 0b415fc..f908983 100644 (file)
@@ -566,6 +566,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
                           NSP_ETH_TABLE_SIZE, 0);
        if (ret) {
                rte_spinlock_unlock(&desc->nsp_lock);
+               free(entries);
                return ret;
        }
 
@@ -586,6 +587,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
 
        if (i == NSP_ETH_MAX_COUNT) {
                rte_spinlock_unlock(&desc->nsp_lock);
+               free(entries);
                return -EINVAL;
        }
 
@@ -610,6 +612,7 @@ nfp_nsp_eth_config(nspu_desc_t *desc, int port, int up)
                                "Hw ethernet port %d configure failed\n", port);
        }
        rte_spinlock_unlock(&desc->nsp_lock);
+       free(entries);
        return ret;
 }