]> git.droids-corp.org - dpdk.git/commitdiff
net/dpaa2: fix 10G port negotiation
authorRohit Raj <rohit.raj@nxp.com>
Fri, 8 May 2020 13:02:03 +0000 (18:32 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Mon, 11 May 2020 20:27:39 +0000 (22:27 +0200)
Fixed 10G port negotiation issue with another 10G/non 10G port.

When running testpmd with 10G interfaces on 10BaseT interface
on LS2088ARDB, the ports were showing link as down.

This was identified to be caused by the setting of link as down
during config.
Also, the line rate was not being updated in device link params,
thus having the incorrect link speed in status (as 0).

Fixes: c5acbb5ea20e ("net/dpaa2: support link status event")
Cc: stable@dpdk.org
Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
drivers/net/dpaa2/dpaa2_ethdev.c

index 2cde55e7ccc4c5fb9e0ee9a37eb9b25aa44a00db..4fc550a8858a3ad961aeb6df6ba400914dde7354 100644 (file)
@@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
        if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
                dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK);
 
-       /* update the current status */
-       dpaa2_dev_link_update(dev, 0);
-
        return 0;
 }
 
@@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)
        /* changing tx burst function to start enqueues */
        dev->tx_pkt_burst = dpaa2_dev_tx;
        dev->data->dev_link.link_status = state.up;
+       dev->data->dev_link.link_speed = state.rate;
 
        if (state.up)
                DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);