]> git.droids-corp.org - dpdk.git/commitdiff
app/eventdev: remove unnecessary barriers in order test
authorFeifei Wang <feifei.wang2@arm.com>
Thu, 14 Jan 2021 07:08:30 +0000 (15:08 +0800)
committerJerin Jacob <jerinj@marvell.com>
Tue, 26 Jan 2021 14:32:18 +0000 (15:32 +0100)
For the wmb in order_process_stage_1 and order_process_stage_invalid in
the order test, they can be removed. This is because when the test results
are wrong, the worker core writes 'true' to t->err. Then other worker
cores, producer cores and the main core will load the 'error' index and
stop testing. So, for the worker cores, no other storing operation needs
to be guaranteed after this when errors happen.

Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
app/test-eventdev/test_order_common.h

index 5ef840493826ee63c23916ea71b2ce3e4a9ed373..cd9d6009ec7c89f77baececbca98a1e9cfbad29d 100644 (file)
@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order *const t,
                        flow, *order_mbuf_seqn(t, ev->mbuf),
                        expected_flow_seq[flow]);
                t->err = true;
-               rte_smp_wmb();
        }
        /*
         * Events from an atomic flow of an event queue can be scheduled only to
@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order *const t,
 {
        evt_err("invalid queue %d", ev->queue_id);
        t->err = true;
-       rte_smp_wmb();
 }
 
 #define ORDER_WORKER_INIT\