net/ena/base: fix type conversions by explicit casting
authorMichal Krawczyk <mk@semihalf.com>
Tue, 11 May 2021 06:45:40 +0000 (08:45 +0200)
committerFerruh Yigit <ferruh.yigit@intel.com>
Tue, 11 May 2021 13:00:43 +0000 (15:00 +0200)
To silence error messages from the static code analysis, make the type
conversions explicit where they're intended.

Also fix the type for the DMA width value.

Fixes: 99ecfbf845b3 ("ena: import communication layer")
Cc: stable@dpdk.org
Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Guy Tzalik <gtzalik@amazon.com>
drivers/net/ena/base/ena_com.c

index 9dc9f28..0cdeb1a 100644 (file)
@@ -1382,7 +1382,7 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue,
                                    "Failed to submit command [%ld]\n",
                                    PTR_ERR(comp_ctx));
 
-               return PTR_ERR(comp_ctx);
+               return (int)PTR_ERR(comp_ctx);
        }
 
        ret = ena_com_wait_and_process_admin_cq(comp_ctx, admin_queue);
@@ -1602,7 +1602,7 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag)
 int ena_com_get_dma_width(struct ena_com_dev *ena_dev)
 {
        u32 caps = ena_com_reg_bar_read32(ena_dev, ENA_REGS_CAPS_OFF);
-       int width;
+       u32 width;
 
        if (unlikely(caps == ENA_MMIO_READ_TIMEOUT)) {
                ena_trc_err(ena_dev, "Reg read timeout occurred\n");
@@ -2280,7 +2280,7 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu)
        cmd.aq_common_descriptor.opcode = ENA_ADMIN_SET_FEATURE;
        cmd.aq_common_descriptor.flags = 0;
        cmd.feat_common.feature_id = ENA_ADMIN_MTU;
-       cmd.u.mtu.mtu = mtu;
+       cmd.u.mtu.mtu = (u32)mtu;
 
        ret = ena_com_execute_admin_command(admin_queue,
                                            (struct ena_admin_aq_entry *)&cmd,
@@ -2691,7 +2691,7 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev)
                return ret;
        }
 
-       cmd.control_buffer.length = (1ULL << rss->tbl_log_size) *
+       cmd.control_buffer.length = (u32)(1ULL << rss->tbl_log_size) *
                sizeof(struct ena_admin_rss_ind_table_entry);
 
        ret = ena_com_execute_admin_command(admin_queue,
@@ -2713,7 +2713,7 @@ int ena_com_indirect_table_get(struct ena_com_dev *ena_dev, u32 *ind_tbl)
        u32 tbl_size;
        int i, rc;
 
-       tbl_size = (1ULL << rss->tbl_log_size) *
+       tbl_size = (u32)(1ULL << rss->tbl_log_size) *
                sizeof(struct ena_admin_rss_ind_table_entry);
 
        rc = ena_com_get_feature_ex(ena_dev, &get_resp,