net/i40e: populate error in flow director parser

Errors from i40e_flow_parse_fdir_pattern() can bubble up to
rte_flow_create. If rte_flow_error is not initialized a caller may
dereference error->message. This may be uninitialized memory, leading
to a segemntation fault.

Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate")
Cc: stable@dpdk.org
Signed-off-by: Mike Pattrick <mkp@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index e0cf99620033d1bc1af15662c80630145c79a5c7..4f3808cb5ff34e68ee5cda3d55674e4ef4f90817 100644 (file)
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -3142,8 +3142,11 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev,
                /* Check if the input set is valid */
                if (i40e_validate_input_set(pctype, RTE_ETH_FILTER_FDIR,
                                                input_set) != 0) {
-                       PMD_DRV_LOG(ERR, "Invalid input set");
-                       return -EINVAL;
+                       rte_flow_error_set(error, EINVAL,
+                                          RTE_FLOW_ERROR_TYPE_ITEM,
+                                          item,
+                                          "Invalid input set");
+                       return -rte_errno;
                }
 
                filter->input.flow_ext.input_set = input_set;