]> git.droids-corp.org - dpdk.git/commitdiff
net/bnxt: fix restoring VLAN filtering after recovery
authorKalesh AP <kalesh-anakkur.purayil@broadcom.com>
Tue, 4 Jan 2022 08:38:11 +0000 (14:08 +0530)
committerAjit Khaparde <ajit.khaparde@broadcom.com>
Wed, 12 Jan 2022 01:48:54 +0000 (02:48 +0100)
During port start, driver calls bnxt_vlan_offload_set_op()
to program VLAN Filter/VLAN Strip setting to the HW. This
in turns add the vlan filters.

This results in a failure when bnxt_restore_filters() invokes
bnxt_restore_vlan_filters() during the recovery as the vlans are
already programmed.

Fix to ignore the error(-EEXIST).

Fixes: 151c8240ac6a ("net/bnxt: restore VLAN filters during reset recovery")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
drivers/net/bnxt/bnxt_ethdev.c

index dcf283921595937da742b0db74da5817520020fb..99a7d35470bf3252080bbac8959a4def540a1289 100644 (file)
@@ -4308,8 +4308,9 @@ static int bnxt_restore_filters(struct bnxt *bp)
        if (ret)
                return ret;
 
+       /* if vlans are already programmed, this can fail with -EEXIST */
        ret = bnxt_restore_vlan_filters(bp);
-       if (ret)
+       if (ret && ret != -EEXIST)
                return ret;
 
        ret = bnxt_restore_mcast_mac_filters(bp);