test/hash: replace sprintf with snprintf
authorPallantla Poornima <pallantlax.poornima@intel.com>
Tue, 26 Mar 2019 10:27:23 +0000 (10:27 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Fri, 5 Apr 2019 08:40:56 +0000 (10:40 +0200)
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.

Fixes: 473d1bebce ("hash: allow to store data in hash table")
Cc: stable@dpdk.org
Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
app/test/test_hash_perf.c

index 5252111..5648fce 100644 (file)
@@ -85,9 +85,11 @@ create_table(unsigned int with_data, unsigned int table_index,
 
        if (with_data)
                /* Table will store 8-byte data */
-               sprintf(name, "test_hash%d_data", hashtest_key_lens[table_index]);
+               snprintf(name, sizeof(name), "test_hash%u_data",
+                               hashtest_key_lens[table_index]);
        else
-               sprintf(name, "test_hash%d", hashtest_key_lens[table_index]);
+               snprintf(name, sizeof(name), "test_hash%u",
+                               hashtest_key_lens[table_index]);
 
 
        if (with_locks)