raw/skeleton: fix memory leak on test failure
authorShreyansh Jain <shreyansh.jain@nxp.com>
Wed, 24 Oct 2018 05:33:41 +0000 (05:33 +0000)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 24 Oct 2018 22:59:28 +0000 (00:59 +0200)
In skeleton_rawdev unit tests, a malloc'd memory was leaking in case
the next sequential test fails. This fix moves the free of the
malloc'd memory above the failing test.

Coverity issue: 260402
Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c

index 3405b89..359c9e2 100644 (file)
@@ -294,13 +294,14 @@ test_rawdev_attr_set_get(void)
                              "Attribute (Test1) not set correctly (%" PRIu64 ")",
                              ret_value);
 
+       free(dummy_value);
+
        ret_value = 0;
        ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value);
        RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200,
                              "Attribute (Test2) not set correctly (%" PRIu64 ")",
                              ret_value);
 
-       free(dummy_value);
        return TEST_SUCCESS;
 }