examples/ip_pipeline: fix leak on connection error
authorKevin Laatz <kevin.laatz@intel.com>
Thu, 19 Apr 2018 11:04:18 +0000 (12:04 +0100)
committerCristian Dumitrescu <cristian.dumitrescu@intel.com>
Tue, 8 May 2018 11:06:16 +0000 (13:06 +0200)
Closing the fd_server file descriptor on error to fix the resource leak.

Coverity issue: 272587
Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
examples/ip_pipeline/conn.c

index 9338942..6b08e9e 100644 (file)
@@ -96,12 +96,14 @@ conn_init(struct conn_params *p)
                sizeof(server_address));
        if (status == -1) {
                conn_free(conn);
+               close(fd_server);
                return NULL;
        }
 
        status = listen(fd_server, 16);
        if (status == -1) {
                conn_free(conn);
+               close(fd_server);
                return NULL;
        }
 
@@ -109,6 +111,7 @@ conn_init(struct conn_params *p)
        fd_client_group = epoll_create(1);
        if (fd_client_group == -1) {
                conn_free(conn);
+               close(fd_server);
                return NULL;
        }