net/bnxt: cleanup MTU setting

Minor cleanup in bnxt_mtu_set_op() to move pre-mature
setting of jumbo flag post mtu check and remove
a redundant mtu set operation from rxq vnic configs.

Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Cc: stable@dpdk.org
Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index f040cdcf948e6a4e5d05efaa46845213c6f2279d..e275d3a53fda3080f85095f4e8b9f77f58726452 100644 (file)
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3037,15 +3037,15 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
        if (!eth_dev->data->nb_rx_queues)
                return -ENOTSUP;
 
+       /* Is there a change in mtu setting? */
+       if (eth_dev->data->mtu == new_mtu)
+               return 0;
+
        if (new_mtu > RTE_ETHER_MTU)
                bp->flags |= BNXT_FLAG_JUMBO;
        else
                bp->flags &= ~BNXT_FLAG_JUMBO;
 
-       /* Is there a change in mtu setting? */
-       if (eth_dev->data->mtu == new_mtu)
-               return 0;
-
        for (i = 0; i < bp->nr_vnics; i++) {
                struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
                uint16_t size = 0;

diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index f4b641773d7883e426283dd052b2439313d7d9ad..fabbbd4560e5a05482a93d3b9d5a2f9fc6c71f17 100644 (file)
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -402,10 +402,6 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev,
        rxq->rx_started = rxq->rx_deferred_start ? false : true;
        rxq->vnic = BNXT_GET_DEFAULT_VNIC(bp);
 
-       /* Configure mtu if it is different from what was configured before */
-       if (!queue_idx)
-               bnxt_mtu_set_op(eth_dev, eth_dev->data->mtu);
-
        return 0;
 err:
        bnxt_rx_queue_release_op(eth_dev, queue_idx);