test/telemetry: fix socket resource leak

If an error occurred when reading from the socket, the function
returned without closing the socket. This is now fixed to avoid the
resource leak of the sock variable going out of scope.

Coverity issue: 363043
Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON")
Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>

diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c
index 00326867b6a0474cd08ea50e5cdcab7b4b550894..f34d691265f33fb5a050dfd408ec7dc8ebb80a5f 100644 (file)
--- a/app/test/test_telemetry_data.c
+++ b/app/test/test_telemetry_data.c
@@ -330,6 +330,7 @@ connect_to_socket(void)
        if (bytes < 0) {
                printf("%s: Error with socket read - %s\n", __func__,
                                strerror(errno));
+               close(sock);
                return -1;
        }
        buf[bytes] = '\0';