eal: use safe snprintf to print version
authorBruce Richardson <bruce.richardson@intel.com>
Tue, 16 Dec 2014 16:30:24 +0000 (16:30 +0000)
committerThomas Monjalon <thomas.monjalon@6wind.com>
Tue, 16 Dec 2014 23:40:37 +0000 (00:40 +0100)
When printing the version string to a local variable, use snprintf for
safety over sprintf. This is general good practice even if the values
to print are all hard-coded.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
lib/librte_eal/common/include/rte_version.h

index 54cb9a6..356207c 100644 (file)
@@ -104,13 +104,13 @@ rte_version(void)
        if (version[0] != 0)
                return version;
        if (strlen(RTE_VER_SUFFIX) == 0)
-               sprintf(version, "%s %d.%d.%d",
+               snprintf(version, sizeof(version), "%s %d.%d.%d",
                        RTE_VER_PREFIX,
                        RTE_VER_MAJOR,
                        RTE_VER_MINOR,
                        RTE_VER_PATCH_LEVEL);
        else
-               sprintf(version, "%s %d.%d.%d%s%d",
+               snprintf(version, sizeof(version), "%s %d.%d.%d%s%d",
                        RTE_VER_PREFIX,
                        RTE_VER_MAJOR,
                        RTE_VER_MINOR,