]> git.droids-corp.org - dpdk.git/commitdiff
net/mlx5: remove ineffective increment in hairpin split
authorMichael Baum <michaelba@mellanox.com>
Tue, 21 Jul 2020 12:00:04 +0000 (12:00 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Wed, 29 Jul 2020 22:41:23 +0000 (00:41 +0200)
The flow_hairpin_split function defines a pointer called addr that
points to the list of items.
When the function wants to progress in the list, it adds the size of an
item to the pointer.

At the end of the function, it precedes the pointer one more time even
though it is not used afterwards. In fact, this line is unaffected and
the operation of the function would have been no different without it.

Remove the line where the pointer is preceded unnecessarily.

Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
drivers/net/mlx5/mlx5_flow.c

index 742f9dd8a0b086600898b88b8cb6e5eecf559b81..71501730b5127b9704f6e4f2140879bb02f7a0c4 100644 (file)
@@ -3518,7 +3518,6 @@ flow_hairpin_split(struct rte_eth_dev *dev,
        tag_item->data = UINT32_MAX;
        tag_item->id = UINT16_MAX;
        item->mask = tag_item;
-       addr += sizeof(struct mlx5_rte_flow_item_tag);
        item->last = NULL;
        item++;
        item->type = RTE_FLOW_ITEM_TYPE_END;