app/testpmd: change port link speed without stopping all
authorHuisong Li <lihuisong@huawei.com>
Wed, 28 Apr 2021 08:36:59 +0000 (16:36 +0800)
committerAndrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru>
Fri, 2 Jul 2021 17:03:03 +0000 (19:03 +0200)
When we use the following cmd to modify the link speed of specified
port: "port config <port_id> speed xxx duplex xxx", we have to stop
all ports. It's not necessary.

Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
app/test-pmd/cmdline.c

index bfd2fb9..8468018 100644 (file)
@@ -1619,13 +1619,13 @@ cmd_config_speed_specific_parsed(void *parsed_result,
        struct cmd_config_speed_specific *res = parsed_result;
        uint32_t link_speed;
 
-       if (!all_ports_stopped()) {
-               printf("Please stop all ports first\n");
+       if (port_id_is_invalid(res->id, ENABLED_WARN))
                return;
-       }
 
-       if (port_id_is_invalid(res->id, ENABLED_WARN))
+       if (!port_is_stopped(res->id)) {
+               printf("Please stop port %d first\n", res->id);
                return;
+       }
 
        if (parse_and_check_speed_duplex(res->value1, res->value2,
                        &link_speed) < 0)