eal: fix service core list parsing
authorChengwen Feng <fengchengwen@huawei.com>
Wed, 5 May 2021 04:10:07 +0000 (12:10 +0800)
committerThomas Monjalon <thomas@monjalon.net>
Wed, 5 May 2021 21:19:23 +0000 (23:19 +0200)
This patch adds checking for service core index validity when parsing
service corelist.

Fixes: 7dbd7a6413ef ("service: add -S corelist option")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
lib/eal/common/eal_common_options.c

index 66f9114..97ab6e0 100644 (file)
@@ -758,10 +758,10 @@ static int
 eal_parse_service_corelist(const char *corelist)
 {
        struct rte_config *cfg = rte_eal_get_configuration();
-       int i, idx = 0;
+       int i;
        unsigned count = 0;
        char *end = NULL;
-       int min, max;
+       uint32_t min, max, idx;
        uint32_t taken_lcore_count = 0;
 
        if (corelist == NULL)
@@ -785,6 +785,8 @@ eal_parse_service_corelist(const char *corelist)
                idx = strtoul(corelist, &end, 10);
                if (errno || end == NULL)
                        return -1;
+               if (idx >= RTE_MAX_LCORE)
+                       return -1;
                while (isblank(*end))
                        end++;
                if (*end == '-') {