]> git.droids-corp.org - dpdk.git/commitdiff
app/testpmd: revert MAC update in checksum forwarding
authorMaxime Coquelin <maxime.coquelin@redhat.com>
Wed, 8 Jun 2022 12:49:41 +0000 (14:49 +0200)
committerMaxime Coquelin <maxime.coquelin@redhat.com>
Fri, 17 Jun 2022 12:41:04 +0000 (14:41 +0200)
This patch reverts
commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"),
as the checksum forwarding is expected to only perform
checksum and not also overwrites the source and destination MAC addresses.

Doing so, we can test checksum offloading with real traffic
without breaking broadcast packets.

Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding")
Cc: stable@dpdk.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Chenbo Xia <chenbo.xia@intel.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>
app/test-pmd/csumonly.c

index 7df201e04730e7043f111795e45185108d17ca5f..1a3fd9ce8a75dc290b97e7d2e630e7788ffd494b 100644 (file)
@@ -916,10 +916,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
                 * and inner headers */
 
                eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
-               rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
-                               &eth_hdr->dst_addr);
-               rte_ether_addr_copy(&ports[fs->tx_port].eth_addr,
-                               &eth_hdr->src_addr);
                parse_ethernet(eth_hdr, &info);
                l3_hdr = (char *)eth_hdr + info.l2_len;