bus/pci: copy new id for inserted device on Linux
authorJim Harris <james.r.harris@intel.com>
Tue, 13 Oct 2020 17:03:16 +0000 (10:03 -0700)
committerThomas Monjalon <thomas@monjalon.net>
Tue, 13 Oct 2020 21:10:18 +0000 (23:10 +0200)
When a device is inserted into an existing BDF slot
that has not been probed, we must overwrite the old
PCI ID with the ID of the new function. Otherwise
we may not probe the function with the correct driver,
if at all.

Signed-off-by: Jim Harris <james.r.harris@intel.com>
drivers/bus/pci/linux/pci.c

index bf27594..619d209 100644 (file)
@@ -352,6 +352,7 @@ pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)
                                if (!rte_dev_is_probed(&dev2->device)) {
                                        dev2->kdrv = dev->kdrv;
                                        dev2->max_vfs = dev->max_vfs;
+                                       dev2->id = dev->id;
                                        pci_name_set(dev2);
                                        memmove(dev2->mem_resource,
                                                dev->mem_resource,
@@ -365,7 +366,8 @@ pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)
                                         * need to do anything here unless...
                                         **/
                                        if (dev2->kdrv != dev->kdrv ||
-                                               dev2->max_vfs != dev->max_vfs)
+                                               dev2->max_vfs != dev->max_vfs ||
+                                               memcmp(&dev2->id, &dev->id, sizeof(dev2->id)))
                                                /*
                                                 * This should not happens.
                                                 * But it is still possible if