net/bnxt: fix crash during Tx
authorAjit Khaparde <ajit.khaparde@broadcom.com>
Mon, 13 Jul 2020 05:17:59 +0000 (10:47 +0530)
committerFerruh Yigit <ferruh.yigit@intel.com>
Fri, 17 Jul 2020 16:21:21 +0000 (18:21 +0200)
When TRUFLOW is not enabled ulp_ctx is not allocated.
In non-vector Tx datapath we are accessing this invalid pointer
resulting in a segfault. Check if TRUFLOW is enabled before
accessing ulp_ctx to avoid this.

Fixes: 1e46b3962620 ("net/bnxt: fill cfa action in Tx descriptor")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
drivers/net/bnxt/bnxt_txr.c

index f588426..c741c71 100644 (file)
@@ -132,8 +132,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,
                                PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN |
                                PKT_TX_TUNNEL_GENEVE | PKT_TX_IEEE1588_TMST |
                                PKT_TX_QINQ_PKT) ||
-            txq->bp->ulp_ctx->cfg_data->tx_cfa_action ||
-            txq->vfr_tx_cfa_action)
+            (BNXT_TRUFLOW_EN(txq->bp) &&
+             (txq->bp->ulp_ctx->cfg_data->tx_cfa_action ||
+              txq->vfr_tx_cfa_action)))
                long_bd = true;
 
        nr_bds = long_bd + tx_pkt->nb_segs;