drivers/crypto: fix session-less mode
authorJunxiao Shi <git@mail1.yoursunny.com>
Mon, 27 Jan 2020 18:32:11 +0000 (11:32 -0700)
committerAkhil Goyal <akhil.goyal@nxp.com>
Thu, 13 Feb 2020 11:41:21 +0000 (12:41 +0100)
When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode
for symmetric crypto operation (e.g. SHA256 hash), the driver prints
error message:

    CRYPTODEV: set_sym_session_private_data() line 489:
               Set private data for driver 0 not allowed

Then, AESNI-MB driver segfaults in post_process_mb_job().

Bugzilla ID: 377
Fixes: b3bbd9e5f2 ("cryptodev: support device independent sessions")
Fixes: c68d7aa354 ("crypto/aesni_mb: use architecture independent macros")
Cc: stable@dpdk.org
Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c
drivers/crypto/openssl/rte_openssl_pmd.c

index 97d9f81..33f4167 100644 (file)
@@ -729,10 +729,10 @@ get_session(struct aesni_mb_qp *qp, struct rte_crypto_op *op)
                                        op->sym->session,
                                        cryptodev_driver_id);
        } else {
-               void *_sess = NULL;
+               void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp);
                void *_sess_private_data = NULL;
 
-               if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+               if (_sess == NULL)
                        return NULL;
 
                if (rte_mempool_get(qp->sess_mp_priv,
index 91f0283..199097b 100644 (file)
@@ -762,10 +762,10 @@ get_session(struct openssl_qp *qp, struct rte_crypto_op *op)
                        return NULL;
 
                /* provide internal session */
-               void *_sess = NULL;
+               void *_sess = rte_cryptodev_sym_session_create(qp->sess_mp);
                void *_sess_private_data = NULL;
 
-               if (rte_mempool_get(qp->sess_mp, (void **)&_sess))
+               if (_sess == NULL)
                        return NULL;
 
                if (rte_mempool_get(qp->sess_mp_priv,