net/pcap: remove local variable shadowing outer one
authorFerruh Yigit <ferruh.yigit@intel.com>
Thu, 19 Nov 2020 11:58:55 +0000 (11:58 +0000)
committerDavid Marchand <david.marchand@redhat.com>
Mon, 11 Jan 2021 09:45:34 +0000 (10:45 +0100)
'ret' is already defined in the function scope, removing the 'ret' in
the block scope.

Fixes: c9507cd0cada ("net/pcap: support physical interface MAC address")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
drivers/net/pcap/rte_eth_pcap.c

index 4930d7d..a32b1f3 100644 (file)
@@ -1324,9 +1324,8 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
 
                /* phy_mac arg is applied only only if "iface" devarg is provided */
                if (rx_queues->phy_mac) {
-                       int ret = eth_pcap_update_mac(rx_queues->queue[0].name,
-                                       eth_dev, vdev->device.numa_node);
-                       if (ret == 0)
+                       if (eth_pcap_update_mac(rx_queues->queue[0].name,
+                                       eth_dev, vdev->device.numa_node) == 0)
                                internals->phy_mac = 1;
                }
        }