]> git.droids-corp.org - dpdk.git/commitdiff
net/mlx5: fix LRO validation in Rx setup
authorMichael Baum <michaelba@nvidia.com>
Mon, 25 Apr 2022 09:30:19 +0000 (12:30 +0300)
committerRaslan Darawsheh <rasland@nvidia.com>
Tue, 26 Apr 2022 09:52:18 +0000 (11:52 +0200)
The mlx5_rx_queue_setup() get LRO offload from user.

When LRO is configured, the LRO flag in rxq_data is set to 1.

This patch adds validation to make sure the LRO is supported.

Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
drivers/net/mlx5/mlx5_rxq.c

index 981c296f29dbeda18147b4c7b9b36b9bcbdb78ae..a2d03f9f67b04648b85410d498db7043f5d8daed 100644 (file)
@@ -842,6 +842,14 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
                            dev->data->dev_conf.rxmode.offloads;
        bool is_extmem = false;
 
+       if ((offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) &&
+           !priv->sh->dev_cap.lro_supported) {
+               DRV_LOG(ERR,
+                       "Port %u queue %u LRO is configured but not supported.",
+                       dev->data->port_id, idx);
+               rte_errno = EINVAL;
+               return -rte_errno;
+       }
        if (mp) {
                /*
                 * The parameters should be checked on rte_eth_dev layer.