net/hns3: fix Rx queue search with broadcast packet

Currently, there is a certain probability of a type of RAS errors when
receiving broadcast packets. This type of RAS errors are parsed as
rx_q_search_miss error by hns3 PF PMD driver, the related log as below:
0000:bd:00.0 hns3_find_highest_level(): PPP_MFP_ABNORMAL_INT_ST2
rx_q_search_miss found [error status=0x20000000]

When receiving broadcast packet, network engine select which functions
need to accept it according to the function's promisc_bcast_en bit
configuration. And then search TQP_MAP configuration to select which
hardware queues the packet should enter, if can't find the target
hardware queue, network engine will trigger rx_q_search_miss RAS error.

The root cause as below:
1. VF's promisc_bcast_en bit configuration is not cleared by FLR reset,
   and the configuration has been set in the previous application.
2. There is one bug in setting TQP_MAP configuration in the
   initialization of PF device: when tqp is allocated to VF, it is still
   marked as PF.  This issue will affect the correctness of the TQP_MAP
   configuration.

This patch fixes it with the following modification.
1. Clear all VFs promisc_bcast_en bit in the initialization of PF
   device.
2. Fix the issue to ensure the correct TQP_MAP configuration.

Fixes: d51867db65c1 ("net/hns3: add initialization")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 800fa47..ca87180 100644 (file)
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2408,6 +2408,7 @@ hns3_query_pf_resource(struct hns3_hw *hw)
        hw->total_tqps_num = rte_le_to_cpu_16(req->tqp_num);
        pf->pkt_buf_size = rte_le_to_cpu_16(req->buf_size) << HNS3_BUF_UNIT_S;
        hw->tqps_num = RTE_MIN(hw->total_tqps_num, HNS3_MAX_TQP_NUM_PER_FUNC);
+       pf->func_num = rte_le_to_cpu_16(req->pf_own_fun_number);
 
        if (req->tx_buf_size)
                pf->tx_buf_size =
@@ -2684,6 +2685,7 @@ hns3_map_tqp(struct hns3_hw *hw)
        uint16_t tqps_num = hw->total_tqps_num;
        uint16_t func_id;
        uint16_t tqp_id;
+       bool is_pf;
        int num;
        int ret;
        int i;
@@ -2695,10 +2697,11 @@ hns3_map_tqp(struct hns3_hw *hw)
        tqp_id = 0;
        num = DIV_ROUND_UP(hw->total_tqps_num, HNS3_MAX_TQP_NUM_PER_FUNC);
        for (func_id = 0; func_id < num; func_id++) {
+               is_pf = func_id == 0 ? true : false;
                for (i = 0;
                     i < HNS3_MAX_TQP_NUM_PER_FUNC && tqp_id < tqps_num; i++) {
                        ret = hns3_map_tqps_to_func(hw, func_id, tqp_id++, i,
-                                                   true);
+                                                   is_pf);
                        if (ret)
                                return ret;
                }
@@ -3599,6 +3602,26 @@ hns3_set_promisc_mode(struct hns3_hw *hw, bool en_uc_pmc, bool en_mc_pmc)
        return 0;
 }
 
+static int
+hns3_clear_all_vfs_promisc_mode(struct hns3_hw *hw)
+{
+       struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
+       struct hns3_pf *pf = &hns->pf;
+       struct hns3_promisc_param param;
+       uint16_t func_id;
+       int ret;
+
+       /* func_id 0 is denoted PF, the VFs start from 1 */
+       for (func_id = 1; func_id < pf->func_num; func_id++) {
+               hns3_promisc_param_init(&param, false, false, false, func_id);
+               ret = hns3_cmd_set_promisc_mode(hw, &param);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
 static int
 hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 {
@@ -3886,6 +3909,13 @@ hns3_init_hardware(struct hns3_adapter *hns)
                goto err_mac_init;
        }
 
+       ret = hns3_clear_all_vfs_promisc_mode(hw);
+       if (ret) {
+               PMD_INIT_LOG(ERR, "Failed to clear all vfs promisc mode: %d",
+                            ret);
+               goto err_mac_init;
+       }
+
        ret = hns3_init_vlan_config(hns);
        if (ret) {
                PMD_INIT_LOG(ERR, "Failed to init vlan: %d", ret);

diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index 2aa4c3c..d4a0306 100644 (file)
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -464,6 +464,7 @@ struct hns3_mp_param {
 struct hns3_pf {
        struct hns3_adapter *adapter;
        bool is_main_pf;
+       uint16_t func_num; /* num functions of this pf, include pf and vfs */
 
        uint32_t pkt_buf_size; /* Total pf buf size for tx/rx */
        uint32_t tx_buf_size; /* Tx buffer size for each TC */