]> git.droids-corp.org - dpdk.git/commitdiff
net/hns3: fix link status capability query from VF
authorHuisong Li <lihuisong@huawei.com>
Sat, 11 Jun 2022 07:42:26 +0000 (15:42 +0800)
committerFerruh Yigit <ferruh.yigit@xilinx.com>
Fri, 24 Jun 2022 11:10:01 +0000 (13:10 +0200)
Currently, the VF LSC capability is obtained from PF driver in
the interrupt mailbox interrupt thread, it is asynchronous.
The VF driver waits for 500ms to get this capability in probe
process.

The primary process will receive a message and do probe in the
interrupt thread context when attach a device in the secondary
process. At this case, VF driver never obtains this capability
from PF.

The root cause is that 'vf->pf_push_lsc_cap' is not updated by
the handling mailbox thread until finishing probe. The reason
this update wouldn't be done is that the handling mailbox interrupt
thread and the probe alarm thread are both in epool thread, and
the probe alarm thread is before the mailbox interrupt thread.

Fixes: 9bc2289fe5ea ("net/hns3: refactor VF LSC event report")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
drivers/net/hns3/hns3_ethdev_vf.c

index bebfaa6417fcb3bfae1efb7381cc0ebc54f826ab..3abd4aafcb0650e50694b09229c02ec3235f2833 100644 (file)
@@ -777,6 +777,14 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
 
        while (remain_ms > 0) {
                rte_delay_ms(HNS3_POLL_RESPONE_MS);
+               /*
+                * The probe process may perform in interrupt thread context.
+                * For example, users attach a device in the secondary process.
+                * At the moment, the handling mailbox task will be blocked. So
+                * driver has to actively handle the HNS3_MBX_LINK_STAT_CHANGE
+                * mailbox from PF driver to get this capability.
+                */
+               hns3_dev_handle_mbx_msg(hw);
                if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=
                        HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
                        break;