net/ixgbe/base: improve log about autoneg being disabled
authorGuinan Sun <guinanx.sun@intel.com>
Thu, 9 Jul 2020 08:00:41 +0000 (08:00 +0000)
committerFerruh Yigit <ferruh.yigit@intel.com>
Sat, 11 Jul 2020 04:18:53 +0000 (06:18 +0200)
On ESXi OS, when user disables auto negotiation, the following log
appears: "(unsupported) Flow control autoneg is disabled".
It is true that auto negotiation is disabled but it is
not necessarily true that it is not supported.

Signed-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
drivers/net/ixgbe/base/ixgbe_common.c

index 49cee80..59d1794 100644 (file)
@@ -3076,8 +3076,9 @@ void ixgbe_fc_autoneg(struct ixgbe_hw *hw)
         * - link is not up.
         */
        if (hw->fc.disable_fc_autoneg) {
-               ERROR_REPORT1(IXGBE_ERROR_UNSUPPORTED,
-                            "Flow control autoneg is disabled");
+               /* TODO: This should be just an informative log */
+               ERROR_REPORT1(IXGBE_ERROR_CAUTION,
+                             "Flow control autoneg is disabled");
                goto out;
        }