examples/vhost: fix use after free on drain

When a vdev is removed in destroy_device function,
the corresponding vhost TX buffer will also be freed,
but the vhost TX buffer may still be used in the
drain_vhost function, which will cause an error of
heap-use-after-free. Therefore, before accessing
vhost TX buffer, we need to check whether the vdev
has been removed, if so, let's skip this vdev.

Fixes: a68ba8e0a6b6 ("examples/vhost: refactor vhost data path")
Cc: stable@dpdk.org
Signed-off-by: Wenwu Ma <wenwux.ma@intel.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 999809e6ed417e5884cc024b41179b1c423e6445..97218917067e9a271790dfdb5e66086550b02384 100644 (file)
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -914,6 +914,9 @@ drain_vhost_table(void)
        uint64_t cur_tsc;
 
        TAILQ_FOREACH(vdev, &vhost_dev_list, global_vdev_entry) {
+               if (unlikely(vdev->remove == 1))
+                       continue;
+
                vhost_txq = vhost_txbuff[lcore_id * MAX_VHOST_DEVICE
                                                + vdev->vid];