net/mlx5: extend skip scale flag

The sampling feature introduces the scale flow group with factor,
then the scaled table value can be used for the normal path table
due to this table be created implicitly.

But if the input group value already be scaled, for example the
group value of sampling suffix flow, then use 'skip_scale" flag
to skip the scale twice in the translation action.

Consider the flow with jump action and this jump action could be
created implicitly, PMD may only scale the original flow group
value or scale the jump group value or both, so extend the
'skip_scale' flag to two bits:
If bit0 of 'skip_scale' flag is set to 1, then skip the scale the
original flow group;
If bit1 of 'skip_scale' flag is set to 1, then skip the scale the
jump flow group.

Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index d880a9c..7e52246 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -5283,7 +5283,7 @@ flow_create_split_sample(struct rte_eth_dev *dev,
                /* Suffix group level already be scaled with factor, set
                 * skip_scale to 1 to avoid scale again in translation.
                 */
-               flow_split_info->skip_scale = 1;
+               flow_split_info->skip_scale = 1 << MLX5_SCALE_FLOW_GROUP_BIT;
 #endif
        }
        /* Add the suffix subflow. */

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index 8255627..8c705e2 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -767,6 +767,9 @@ struct mlx5_flow_verbs_workspace {
 };
 #endif /* HAVE_INFINIBAND_VERBS_H */
 
+#define MLX5_SCALE_FLOW_GROUP_BIT 0
+#define MLX5_SCALE_JUMP_FLOW_GROUP_BIT 1
+
 /** Maximal number of device sub-flows supported. */
 #define MLX5_NUM_MAX_DEV_FLOWS 32
 
@@ -780,8 +783,20 @@ struct mlx5_flow {
        /**< Bit-fields of detected actions, see MLX5_FLOW_ACTION_*. */
        bool external; /**< true if the flow is created external to PMD. */
        uint8_t ingress:1; /**< 1 if the flow is ingress. */
-       uint8_t skip_scale:1;
-       /**< 1 if skip the scale the table with factor. */
+       uint8_t skip_scale:2;
+       /**
+        * Each Bit be set to 1 if Skip the scale the flow group with factor.
+        * If bit0 be set to 1, then skip the scale the original flow group;
+        * If bit1 be set to 1, then skip the scale the jump flow group if
+        * having jump action.
+        * 00: Enable scale in a flow, default value.
+        * 01: Skip scale the flow group with factor, enable scale the group
+        * of jump action.
+        * 10: Enable scale the group with factor, skip scale the group of
+        * jump action.
+        * 11: Skip scale the table with factor both for flow group and jump
+        * group.
+        */
        union {
 #if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H)
                struct mlx5_flow_dv_workspace dv;
@@ -1251,7 +1266,7 @@ struct flow_grp_info {
        uint64_t fdb_def_rule:1;
        /* force standard group translation */
        uint64_t std_tbl_fix:1;
-       uint64_t skip_scale:1;
+       uint64_t skip_scale:2;
 };
 
 static inline bool

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index f1ce648..74bc1f1 100644 (file)
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -10136,7 +10136,8 @@ flow_dv_translate(struct rte_eth_dev *dev,
                .external = !!dev_flow->external,
                .transfer = !!attr->transfer,
                .fdb_def_rule = !!priv->fdb_def_rule,
-               .skip_scale = !!dev_flow->skip_scale,
+               .skip_scale = dev_flow->skip_scale &
+                       (1 << MLX5_SCALE_FLOW_GROUP_BIT),
        };
 
        if (!wks)
@@ -10494,7 +10495,11 @@ flow_dv_translate(struct rte_eth_dev *dev,
                        jump_group = ((const struct rte_flow_action_jump *)
                                                        action->conf)->group;
                        grp_info.std_tbl_fix = 0;
-                       grp_info.skip_scale = 0;
+                       if (dev_flow->skip_scale &
+                               (1 << MLX5_SCALE_JUMP_FLOW_GROUP_BIT))
+                               grp_info.skip_scale = 1;
+                       else
+                               grp_info.skip_scale = 0;
                        ret = mlx5_flow_group_to_table(dev, tunnel,
                                                       jump_group,
                                                       &table,