bus/pci: fix comment explaining device naming
authorGaetan Rivet <grive@u256.net>
Mon, 16 Nov 2020 10:12:12 +0000 (11:12 +0100)
committerDavid Marchand <david.marchand@redhat.com>
Fri, 20 Nov 2020 08:58:55 +0000 (09:58 +0100)
The original triple negative was hard to read and the attempt
to improve the formulation was commendable, unfortunately the new
comment is the inverse of correct.

Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Gaetan Rivet <grive@u256.net>
Acked-by: Luca Boccassi <bluca@debian.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
drivers/bus/pci/pci_common.c

index b24c069..9b8d769 100644 (file)
@@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev)
        devargs = pci_devargs_lookup(&dev->addr);
        dev->device.devargs = devargs;
 
-       /* If the device is blocked, no rte_devargs exists for it. */
+       /* When using a blocklist, only blocked devices will have
+        * an rte_devargs. Allowed devices won't have one.
+        */
        if (devargs != NULL)
                /* If an rte_devargs exists, the generic rte_device uses the
                 * given name as its name.