log: fix level picked with globbing on type register
authorThomas Monjalon <thomas@monjalon.net>
Tue, 7 Apr 2020 22:47:58 +0000 (00:47 +0200)
committerThomas Monjalon <thomas@monjalon.net>
Thu, 16 Apr 2020 17:19:02 +0000 (19:19 +0200)
When a log type is registered, the level can be picked
by matching saved options.
The check of fnmatch globbing result was reversed.

The same bug was already fixed in a similar function.
This one is acting in log type register function.

Note: this function rte_log_register_type_and_pick_level()
is not used a lot and could be merged with rte_log_register().

Fixes: 6ff0f81d0ef7 ("log: fix pattern matching")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
lib/librte_eal/common/eal_common_log.c

index 7647a91..d7a5f9b 100644 (file)
@@ -320,7 +320,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)
                        continue;
 
                if (opt_ll->pattern) {
-                       if (fnmatch(opt_ll->pattern, name, 0))
+                       if (fnmatch(opt_ll->pattern, name, 0) == 0)
                                level = opt_ll->level;
                } else {
                        if (regexec(&opt_ll->re_match, name, 0, NULL, 0) == 0)