app/test: fix crash after null check

In the kvargs test cases, we were checking for errors by checking if the
returned pointer value was NULL. In the error handling, we then tried to
free back the NULL pointer, which would cause a crash.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c
index b8f5e5ce2b9153595fa44691add3fa58123f8a74..6be85122d17020fa58a82a1db5c5f0946cd81f38 100644 (file)
--- a/app/test/test_kvargs.c
+++ b/app/test/test_kvargs.c
@@ -78,7 +78,6 @@ static int test_valid_kvargs(void)
        kvlist = rte_kvargs_parse(args, valid_keys);
        if (kvlist == NULL) {
                printf("rte_kvargs_parse() error");
-               rte_kvargs_free(kvlist);
                goto fail;
        }
        rte_kvargs_free(kvlist);
@@ -89,7 +88,6 @@ static int test_valid_kvargs(void)
        kvlist = rte_kvargs_parse(args, valid_keys);
        if (kvlist == NULL) {
                printf("rte_kvargs_parse() error");
-               rte_kvargs_free(kvlist);
                goto fail;
        }
        /* call check_handler() for all entries with key="check" */
@@ -150,7 +148,6 @@ static int test_valid_kvargs(void)
        kvlist = rte_kvargs_parse(args, valid_keys);
        if (kvlist == NULL) {
                printf("rte_kvargs_parse() error");
-               rte_kvargs_free(kvlist);
                goto fail;
        }
        /* call check_handler() on all entries with key="check", it